Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating YT8M code with the v2 fork #57

Merged
merged 28 commits into from
May 21, 2018
Merged

Updating YT8M code with the v2 fork #57

merged 28 commits into from
May 21, 2018

Conversation

samihaija
Copy link
Contributor

No description provided.

samihaija and others added 25 commits May 3, 2018 15:56
Add missing download command to readme
Avoids unnecessary directory deletion and prevents error while making new directory if that directory already exists.

If the directory removal is important, suggest:
- adding a warning to the user first. I hadn't expected anything to get deleted by this, and had pointed to a large existing directory.
- replacing os.rmdir with shutil.rmtree. os.rmdir fails on non-empty directories.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@LeegleechN
Copy link
Collaborator

As discussed, we should verify the cloud directions and put them back in after the local directions.

@LeegleechN LeegleechN merged commit 4380290 into google:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants