Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run cargo-semver-checks on all targets #1523

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Jul 15, 2024

Credit to @memark for landing obi1kenobi/cargo-semver-checks-action#82, which unblocked this!

Closes #357

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (2cba5ac) to head (ac34d48).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files          15       15           
  Lines        5563     5563           
=======================================
  Hits         4879     4879           
  Misses        684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@memark memark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshlf joshlf added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@djkoloski djkoloski added this pull request to the merge queue Jul 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2024
Credit to @memark for landing obi1kenobi/cargo-semver-checks-action#82,
which unblocked this!

Per #1565, we do not run on wasm32-wasi yet.

Closes #357
@joshlf joshlf force-pushed the cargo-semver-checks-target branch from 3fc533f to ac34d48 Compare August 1, 2024 13:42
@joshlf joshlf enabled auto-merge August 1, 2024 13:42
@joshlf joshlf added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit b43acd9 Aug 1, 2024
77 checks passed
@joshlf joshlf deleted the cargo-semver-checks-target branch August 1, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Check semver compatibility with all target platforms, not just the host platform
4 participants