Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cargo-zerocopy] Pass failure return codes through #948

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[cargo-zerocopy] Pass failure return codes through #948

merged 1 commit into from
Feb 27, 2024

Conversation

djkoloski
Copy link
Member

Addresses #947

joshlf
joshlf requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a quick turnaround! Two small requests, but otherwise looks good.

cargo.sh Outdated Show resolved Hide resolved
tools/cargo-zerocopy/src/main.rs Show resolved Hide resolved
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
Make Ptr::reborrow public
5a2074a 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
Make Ptr::reborrow public
34b11f0 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this pull request Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
@joshlf
Make Ptr::reborrow public (#949)
ae1182e 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix some uses of FromBytes and NoCell in doc tests
b5d4181 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
This was referenced Feb 26, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix some uses of FromBytes and NoCell in doc tests (#950)
296999d 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix UI tests
8ba25f0 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

While we're here, add an `assert!` that prevents us from running UI
tests when the `derive` feature is disabled. The `derive` feature is
required in order for UI tests to produce sensible output, and running
without it enabled is a common source of mis-steps when developing that
ends up slowing us down.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this pull request Feb 26, 2024
Merged
@joshlf joshlf changed the base branch from main to fix-ui-tests February 26, 2024 20:23
@joshlf joshlf mentioned this pull request Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix UI tests (#951)
2e2eaa7 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

While we're here, add an `assert!` that prevents us from running UI
tests when the `derive` feature is disabled. The `derive` feature is
required in order for UI tests to produce sensible output, and running
without it enabled is a common source of mis-steps when developing that
ends up slowing us down.

This will need to merge before #948 can merge.
Base automatically changed from fix-ui-tests to main February 26, 2024 20:39
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
[derive] Fix UI tests
9d199db 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
[derive] Fix UI tests
dbd5238 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this pull request Feb 26, 2024
Merged
@joshlf joshlf changed the base branch from main to fix-derive-ui-tests February 26, 2024 20:43
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
@joshlf
[derive] Fix UI tests (#954)
9421346 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
Base automatically changed from fix-derive-ui-tests to main February 26, 2024 21:29
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix some uses of NoCell in doc tests
fdff237 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
@joshlf joshlf mentioned this pull request Feb 26, 2024
Merged
@joshlf joshlf changed the base branch from main to no-cell-doc-tests February 26, 2024 21:36
Base automatically changed from no-cell-doc-tests to main February 26, 2024 21:50
@joshlf joshlf mentioned this pull request Feb 26, 2024
Merged
@joshlf joshlf changed the base branch from main to fix-clippy February 26, 2024 21:50
joshlf added a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix some uses of NoCell in doc tests
1626ba5 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix some uses of NoCell in doc tests (#956)
a309a36 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
@joshlf
Fix Clippy lints (#957)
40b550e 
This shouldn't have made it onto `main`, but was able to as a result of
the bug described in #947.

This will need to merge before #948 can merge.
Base automatically changed from fix-clippy to main February 26, 2024 22:09
@joshlf joshlf force-pushed the fix_cargo_exit_codes branch 2 times, most recently from d3c7597 to ca7fe60 Compare February 27, 2024 15:57
@joshlf joshlf added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 978b400 Feb 27, 2024
210 checks passed
@joshlf joshlf deleted the fix_cargo_exit_codes branch February 27, 2024 16:28
@joshlf joshlf mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlf joshlf joshlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djkoloski @joshlf