-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: clean up the Transporter interface. #1407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback signature doesn't seem to be used.
@forty thanks for the contribution, we'll get this triaged soon. |
danielbankhead
added
next major: breaking change
this is a change that we should wait to bundle into the next major version
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Aug 19, 2022
danielbankhead
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This looks great. Since the Transporter
and BodyResponseCallback<T>
interfaces are a part of the public API, this is considered breaking and will roll into the next major release.
danielbankhead
changed the title
chore: clean up the Transporter interface.
chore!: clean up the Transporter interface.
Aug 19, 2022
danielbankhead
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jul 5, 2023
danielbankhead
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jul 10, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 10, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
next major: breaking change
this is a change that we should wait to bundle into the next major version
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello (again),
I took the opportunity that I was looking into it to clean up a bit the Transporter interface, as it seems to be used with Promises everywhere in the project.
Fixes #1405