Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test for return value of runTransaction() #2801

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Adding test for return value of runTransaction() #2801

merged 1 commit into from
Jan 24, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 22, 2018 •
edited
Loading

This adds a test to make sure that Firestore Java doesn't suffer from googleapis/nodejs-firestore#110

Spoiler alert: It doesn't.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2018
@schmidt-sebastian schmidt-sebastian merged commit 42ba222 into googleapis:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad approved these changes

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @pongad @googlebot