Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery: make FieldValue publicly construct-able #2891

Merged
merged 3 commits into from
Feb 12, 2018
Merged

bigquery: make FieldValue publicly construct-able #2891

merged 3 commits into from
Feb 12, 2018

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Feb 12, 2018

so make testing easier for users. Fixes #2880.

so make testing easier for users. Fixes #2880.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2018
@pongad
Copy link
Contributor Author

pongad commented Feb 12, 2018

@vam-google Are you OK with this being public?

@tswast
Copy link
Contributor

tswast commented Feb 12, 2018

Hmm, I think something like #1370 would better cover the desired use case for testing specific query / table values than exposing this as public would. Albeit, that is a bigger project than changing visibility.

@pongad
Copy link
Contributor Author

pongad commented Feb 12, 2018

I agree; doing that would definitely be better. I guess there are 2 options.

  1. We can go ahead with this PR, and mark the newly-public methods @BetaApi. When POJO works, we deprecate them.
  2. We close FieldValue.of is not public #2880 as dup of bigquery: support loading a POJO or Map like GSON does #1370, which is now tracked by feature wiki.

I'll defer to you on the decision. However, I'm slightly leaning towards (1). My reasoning is that, right now, users have to deal FieldValueList.get anyway. If you know what to expect from get, calling of isn't too terrible.

@tswast
Copy link
Contributor

tswast commented Feb 12, 2018

Yeah, (1) makes sense. I agree to keep it as @BetaApi for now.

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming you add @BetaApi.

@pongad pongad merged commit ce6ef37 into googleapis:master Feb 12, 2018
@pongad pongad deleted the pub-fieldvalue branch February 12, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants