Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version bump to snapshot #2966

Merged
merged 6 commits into from
Feb 27, 2018
Merged

Version bump to snapshot #2966

merged 6 commits into from
Feb 27, 2018

Conversation

andreamlin
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 27, 2018
@andreamlin andreamlin removed the request for review from pongad February 27, 2018 17:36
@andreamlin
Copy link
Contributor Author

PTAL

garrettjonesgoogle
garrettjonesgoogle suggested changes Feb 27, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an intermediate commit with versions set to release-only versions (no snapshots), so that we have a commit that reflects the code that was released to maven

@andreamlin
Copy link
Contributor Author

Ok, intermediate commit has been pushed to master.

garrettjonesgoogle
garrettjonesgoogle approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 80d6424 into googleapis:master Feb 27, 2018
@andreamlin andreamlin deleted the version_bump branch February 27, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreamlin @garrettjonesgoogle @googlebot