Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): add ability to filter MDC labels #6430

Merged
merged 5 commits into from
Nov 14, 2019
Merged

fix(logging): add ability to filter MDC labels #6430

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a817b1
fix(logging): add ability to filter MDC labels
codyoss Oct 2, 2019
0e09205
fix pr comments
codyoss Oct 3, 2019
e448857
update copyright date
codyoss Oct 3, 2019
153e9d2
try to fix flackyness
codyoss Oct 3, 2019
dd26744
remove mdc after use
codyoss Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove mdc after use
  • Loading branch information
@codyoss
codyoss committed Oct 17, 2019
commit dd26744ec4b187ba0e14562f50a70a5b5f405a5d
3 changes: 1 addition & 2 deletions ...d-logging-logback/src/test/java/com/google/cloud/logging/logback/LoggingAppenderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,8 @@ public void testAddCustomLoggingEventEnhancers() {
loggingAppender.addLoggingEventEnhancer(CustomLoggingEventEnhancer2.class.getName());
loggingAppender.start();
loggingAppender.doAppend(loggingEvent);

verify(logging);

MDC.remove("mdc1");
Map<String, String> capturedArgumentMap =
capturedArgument.getValue().iterator().next().getLabels();
assertThat(capturedArgumentMap.get("mdc1")).isNull();
Expand Down