Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: owlbot.py to tell it's monorepo #8718

Merged
merged 3 commits into from
Nov 7, 2022
Merged

chore: owlbot.py to tell it's monorepo #8718

merged 3 commits into from
Nov 7, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Nov 2, 2022 •
edited
Loading

owlbot.py in the monorepo pass "monorepo=True" to template function so that the README in the monorepo won't get the migrated note.

The parameter is used here https://github.com/googleapis/synthtool/pull/1687/files#diff-1007dbc396853f636813f152aceeb08bcb4ec03deda4b2473350e487e39d0ba8R492

@suztomo suztomo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2022
@suztomo
Copy link
Member Author

suztomo commented Nov 2, 2022

New Client / generate (pull_request) failed:

remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/googleapis/googleapis-gen.git/'
Traceback (most recent call last):
/home/runner/work/google-cloud-java/google-cloud-java/generation/new_client
  File "/home/runner/work/google-cloud-java/google-cloud-java/generation/new_client/new-client.py", line 298, in <module>
Creating a new module /home/runner/work/google-cloud-java/google-cloud-java/java-apikeys

This is irrelevant to owlbot.py changes.

suztomo
suztomo commented Nov 2, 2022
View reviewed changes
generation/update_owlbot_postprocessor_config.sh
@@ -10,7 +10,7 @@ for dir in $(find . -mindepth 2 -maxdepth 2 -name owlbot.py | sort | xargs dirna
pushd "$dir"

# form a perl command to replace java.common_templates() invocation
perl_command='s/java\.common_templates\(.*\)/java.common_templates(excludes=['
perl_command='s/java\.common_templates\(.*\)/java.common_templates(monorepo=True, excludes=['
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the core change in this pull request.

@suztomo suztomo changed the title chore: owlbot.py to tell the monorepo chore: owlbot.py to tell it's monorepo Nov 2, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 2, 2022
@suztomo suztomo merged commit b6c307c into googleapis:main Nov 7, 2022
@suztomo suztomo deleted the owlbot_py_monorepo_param branch November 7, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @meltsufin @yoshi-kokoro