Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added iam troubleshooter v3 and v3beta api clients #9800

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Sep 5, 2023

New policytroubleshooter client protos are in a different folder than v1. Manually adjusting owlbot file to copy over correctly into the existing module

Tested the Owlbot.yaml file locally and it generates the directories for v3/v3beta correctly:

image

Command to test locally:

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo -v /tmp/googleapis-gen:/googleapis-gen -w /repo   --env HOME=/tmp   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-code   --source-repo=/googleapis-gen   --config-file=java-policy-troubleshooter/.OwlBot.yaml

@alicejli alicejli marked this pull request as ready for review September 5, 2023 17:50
@blakeli0
Copy link
Contributor

blakeli0 commented Sep 5, 2023

Tested the Owlbot.yaml file locally and it generates the directories for v3/v3beta correctly:

Did we ever get a library generation requests for v3beta version? If not, maybe just copy the v3 version? WDYT @suztomo?

@alicejli
Copy link
Contributor Author

alicejli commented Sep 5, 2023

Tested the Owlbot.yaml file locally and it generates the directories for v3/v3beta correctly:

Did we ever get a library generation requests for v3beta version? If not, maybe just copy the v3 version? WDYT @suztomo?

We did not get an explicit library generation request for v3beta, but v3beta does exist in the public protos, and in general (I think) our policy has been to generate libraries for whatever exists in the public protos. Can update to whichever is preferred.

@suztomo
Copy link
Member

suztomo commented Sep 5, 2023

In the ticket that requests library generation, the path to the directory containing proto is explicitly specified up to a version, isn't it?

@alicejli
Copy link
Contributor Author

alicejli commented Sep 5, 2023

In the ticket that requests library generation, the path to the directory containing proto is explicitly specified up to a version, isn't it?

Yes, but for languages like Java we usually automatically update existing modules with new versions as they are published. This library is a bit unique where the new version is published in a different directory than the existing protos, so owlbot didn't catch the new version.

@blakeli0
Copy link
Contributor

blakeli0 commented Sep 8, 2023

We did not get an explicit library generation request for v3beta, but v3beta does exist in the public protos, and in general (I think) our policy has been to generate libraries for whatever exists in the public protos.

I don't think this is true. There is a language section in each library generation request, which sometimes only include a subset of languages, I did see Java being excluded sometimes.

@alicejli alicejli merged commit 668032f into main Sep 8, 2023
32 checks passed
@alicejli alicejli deleted the add_new_policytroubleshooterv3 branch September 8, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants