Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include proto-* and grpc-* in Owlbot settings for java-notebooks #9808

Merged
merged 2 commits into from
Sep 8, 2023
Merged

chore: include proto-* and grpc-* in Owlbot settings for java-notebooks #9808

merged 2 commits into from
Sep 8, 2023

Conversation

mpeddada1
Copy link
Contributor

No description provided.

alicejli
alicejli approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional lines look correct. I think you can probably remove lines 26-39 as the newly added lines would encompass them.

@mpeddada1 mpeddada1 merged commit 6a8ed59 into main Sep 8, 2023
32 checks passed
@mpeddada1 mpeddada1 deleted the notebooks-owlbot branch September 8, 2023 18:56
@mpeddada1 mpeddada1 mentioned this pull request Sep 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejli alicejli alicejli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @alicejli