-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
feat: added flag for implicit dismissal for `DismissDecision` PiperOrigin-RevId: 427766265 Source-Link: googleapis/googleapis@5556c91 Source-Link: googleapis/googleapis-gen@d03fa03 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDAzZmEwM2IyMTc0NjI3ODRkNmJhMzJjY2RkZTRkZmUwYzA2ZjAxNyJ9
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
ApprovalRequestName.ofProjectApprovalRequestName("[PROJECT]", "[APPROVAL_REQUEST]") | ||
.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These things are really what you want in your tests? May be ok for mocks, but probably not for IT tests.
@lesv @stephaniewang526 Any idea if these errors are legitimate or if they're transient? The Access Approval Engineer was eager to get the documentation updates propagated to all the languages. |
Java 8Either something is missing or something was added that shouldn't be. Either way, something needs to be fixed - it's not a transient failure. Does it compile on the engineers desktop? Looking at the lint execution, the only weird thing I see is:
Lint
|
Broken build was due to missing dependencies. |
🤖 I have created a release *beep* *boop* --- ### [2.1.11](v2.1.10...v2.1.11) (2022-02-24) ### Documentation * added resource annotations ([#670](#670)) ([8b0b14f](8b0b14f)) ### Dependencies * update actions/github-script action to v6 ([#672](#672)) ([cbbaf6c](cbbaf6c)) * update dependency com.google.cloud:google-cloud-core to v2.5.0 ([#664](#664)) ([4e7d615](4e7d615)) * update dependency com.google.cloud:google-cloud-core to v2.5.4 ([#678](#678)) ([fcf3ff0](fcf3ff0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
feat: added flag for implicit dismissal for
DismissDecision
PiperOrigin-RevId: 427766265
Source-Link: googleapis/googleapis@5556c91
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d03fa03b217462784d6ba32ccdde4dfe0c06f017
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDAzZmEwM2IyMTc0NjI3ODRkNmJhMzJjY2RkZTRkZmUwYzA2ZjAxNyJ9