Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Job#getQueryResultsStream when using startIndex #1100

Merged

Conversation

felix-d
Copy link
Contributor

@felix-d felix-d commented Apr 13, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes 1099 🦕

@felix-d felix-d requested a review from a team as a code owner April 13, 2022 18:46
@felix-d felix-d requested review from a team and stephaniewang526 April 13, 2022 18:46
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 13, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Apr 13, 2022
@google-cla
Copy link

google-cla bot commented Apr 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@felix-d felix-d force-pushed the fix-getQueryResultsStream-with-startIndex branch from 412f997 to 12cdc7d Compare April 13, 2022 18:50
@steffnay steffnay requested review from steffnay and removed request for stephaniewang526 April 14, 2022 19:42
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2022
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job#getQueryResultsStream fails when passed a startIndex
3 participants