Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove test that depended on protobufjs error, now protobufjs correctly fails not finding the import #483

Merged
merged 7 commits into from
Feb 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/load.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ describe('loadSync', () => {
'../../test/fixtures',
'library.proto'
);
it('should not be able to load test file using protobufjs directly', () => {
const root = protobuf.loadSync(TEST_FILE);
// Common proto that should not have been loaded.
assert.strictEqual(root.lookup('google.api.Http'), null);
});

it('should load a test file that relies on common protos', () => {
const root = googleProtoFiles.loadSync(TEST_FILE);
Expand Down
Loading