fix(deps): upgrade http-proxy-agent to v7 (#2071)

fix(deps): upgrade https-proxy-agent to v7
googleapis · Sep 12, 2023 · cc50a34 · cc50a34
1 parent 13cba14
commit cc50a34
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 59 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -84,8 +84,8 @@
     "detect-indent": "^6.1.0",
     "diff": "^5.0.0",
     "figures": "^3.0.0",
-    "http-proxy-agent": "^5.0.0",
-    "https-proxy-agent": "^5.0.1",
+    "http-proxy-agent": "^7.0.0",
+    "https-proxy-agent": "^7.0.0",
     "js-yaml": "^4.0.0",
     "jsonpath": "^1.1.1",
     "node-html-parser": "^6.0.0",

diff --git a/src/github.ts b/src/github.ts
@@ -224,16 +224,11 @@ export class GitHub {
     }
 
     const {host, port} = defaultProxy;
-
-    return new URL(baseUrl).protocol.replace(':', '') === 'http'
-      ? new HttpProxyAgent({
-          host,
-          port,
-        })
-      : new HttpsProxyAgent({
-          host,
-          port,
-        });
+    if (new URL(baseUrl).protocol.replace(':', '') === 'http') {
+      return new HttpProxyAgent(`http://${host}:${port}`);
+    } else {
+      return new HttpsProxyAgent(`https://${host}:${port}`);
+    }
   }
 
   /**