test: rewrite error handling tests

googleapis · Sep 25, 2023 · 76a384f · 76a384f
1 parent db28dcc
commit 76a384f
Show file tree

Hide file tree

Showing 3 changed files with 283 additions and 35 deletions.
diff --git a/packages/bot-framework/src/app.ts b/packages/bot-framework/src/app.ts
@@ -21,7 +21,7 @@ let handler: HandlerFunction;
     app.on('issues.opened', context => {});
   };
   const webhookHandler = await Bootstrapper.load({});
-  handler = webhookHandler.gcf(appFn);
+  handler = webhookHandler.handler(appFn);
 })();
 
 export {handler};
diff --git a/packages/bot-framework/src/bootstrapper.ts b/packages/bot-framework/src/bootstrapper.ts
@@ -191,10 +191,10 @@ export class Bootstrapper {
   }
 
   server(appFn: ApplicationFunction): http.Server {
-    return getServer(this.gcf(appFn));
+    return getServer(this.handler(appFn));
   }
 
-  gcf(appFn: ApplicationFunction): HandlerFunction {
+  handler(appFn: ApplicationFunction): HandlerFunction {
     // load handlers onto webhooks
     appFn(this.webhooks);
 
@@ -509,7 +509,7 @@ export class Bootstrapper {
     }
 
     try {
-      this.webhooks.receive({
+      await this.webhooks.receive({
         id: botRequest.githubDeliveryId,
         name: botRequest.eventName as any,
         payload: payload as any,