Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [gapic-generator-java] handle shortname type ambiguity in LRO parsing #1710

Closed
wants to merge 3 commits into from
Closed

fix: [gapic-generator-java] handle shortname type ambiguity in LRO parsing #1710

wants to merge 3 commits into from

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented May 24, 2023 •
edited
Loading

WIP PR for #1707.

  • Reproduce generation error through test setup
  • Implement fix
  • Additional tests to verify intended behavior

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emmileaf
Copy link
Contributor Author

Closing in favor of #1726, which uses the showcase-extended module to achieve better test coverage of this change.

@emmileaf emmileaf closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmileaf