chore: manage kokoro graal image with renovate bot #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
requested review from
SurferJeffAtGoogle,
chingor13,
bcoe and
a team
as code owners
burkedavison
approved these changes
Dec 19, 2022
| "enabledManagers": ["regex"], | ||
| "regexManagers": [ | ||
| { | ||
| "fileMatch": ["^synthtool/gcp/templates/java-library/.kokoro/presubmit/graalvm-native.*.cfg"], |
There was a problem hiding this comment.
Please verify whether we need to escape the actual periods in the path:
^synthtool/gcp/templates/java-library/\\.kokoro/presubmit/graalvm-native.*\\.cfg
As shown in example: https://github.com/googleapis/gax-java/blob/main/renovate.json#L13
There was a problem hiding this comment.
Verified with this test setup that the regex without the escape works as expected: https://github.com/mpeddada1/renovate-bot-test/pull/7/files.
We have a few examples that don't use \\: https://github.com/googleapis/google-api-java-client-services/blob/d0b6a8fca7ab5b60c79926ad7919bcae223a099f/renovate.json#L33
chingor13
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in mpeddada1/renovate-bot-test#6