chore: treat java-iam as special structure module #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
commented
Mar 16, 2023
| @@ -331,7 +331,7 @@ def main(): | |||
| main_module = existing_modules[artifact_id] | |||
|
|
|||
| if artifact_id in ["grafeas", "google-cloud-dns", | |||
| "google-cloud-notification"]: | |||
| "google-cloud-notification", "java-iam"]: | |||
There was a problem hiding this comment.
The stacktrace of the error happens in line 479. Existing here will stop hitting the problem.
File "/owlbot/src/fix-poms.py", line 479, in main
update_parent_pom("pom.xml", modules)
|
LGTM with a question: since |
JoeWang1127
approved these changes
Mar 16, 2023
|
Java-iam was recently moved to google-cloud-java. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To treat java-iam as a special-structure module that we don't require fixing their pom files. This will address googleapis/google-cloud-java#9227 (comment)
google-cloud-java repository's java-iam module only has google-iam-policy module, without "proto-" and "grpc-" modules, which are in https://github.com/googleapis/gapic-generator-java/tree/main/java-iam.