Skip to content

Commit

Permalink
Use the health-probes from the controller-runtime as liveness probes. (
Browse files Browse the repository at this point in the history
…#298)

(removed the protocol:tcp from yaml as that's the default).

Tested on robco-ensonic

See b/315345823
  • Loading branch information
ensonic authored Jan 23, 2024
1 parent f33deaa commit d1a9672
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
14 changes: 12 additions & 2 deletions src/app_charts/base/cloud/app-management.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ spec:
env:
- name: GOOGLE_CLOUD_PROJECT
value: {{ .Values.project }}
livenessProbe:
initialDelaySeconds: 15
periodSeconds: 10
httpGet:
port: 8080
path: /healthz
ports:
- name: webhook
containerPort: 9876
Expand All @@ -58,7 +64,6 @@ spec:
type: ClusterIP
ports:
- port: 443
protocol: TCP
targetPort: webhook
selector:
app: app-rollout-controller
Expand Down Expand Up @@ -151,6 +156,12 @@ spec:
env:
- name: GOOGLE_CLOUD_PROJECT
value: {{ .Values.project }}
livenessProbe:
initialDelaySeconds: 15
periodSeconds: 10
httpGet:
port: 8080
path: /healthz
ports:
- name: webhook
containerPort: 9876
Expand Down Expand Up @@ -197,7 +208,6 @@ spec:
type: ClusterIP
ports:
- port: 443
protocol: TCP
targetPort: webhook
selector:
app: chart-assignment-controller
Expand Down
7 changes: 6 additions & 1 deletion src/app_charts/base/robot/app-management.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ spec:
value: {{ .Values.project }}
- name: ROBOT_NAME
value: "{{ .Values.robot.name }}"
livenessProbe:
initialDelaySeconds: 15
periodSeconds: 10
httpGet:
port: 8080
path: /healthz
ports:
- name: webhook
containerPort: 9876
Expand Down Expand Up @@ -73,7 +79,6 @@ spec:
type: ClusterIP
ports:
- port: 443
protocol: TCP
targetPort: webhook
selector:
app: chart-assignment-controller
Expand Down

0 comments on commit d1a9672

Please sign in to comment.