WIP: switch from rules_docker to rules_oci #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensonic
reviewed
Jul 10, 2023
| @@ -69,7 +69,6 @@ def push_all(name, images = {}, **kwargs): | |||
| push_targets.append(push_target) | |||
| container_push( | |||
| name = push_target, | |||
| format = "Docker", | |||
There was a problem hiding this comment.
We need to change line 23 and replace --dst wth --repository and --tag
ensonic
reviewed
Jul 10, 2023
deploy.sh
Outdated
| @@ -118,7 +118,7 @@ function terraform_init { | |||
| fi | |||
|
|
|||
| local ROBOT_IMAGE_DIGEST | |||
| ROBOT_IMAGE_DIGEST=$(cat bazel-bin/src/go/cmd/setup-robot/setup-robot.push.digest) | |||
| ROBOT_IMAGE_DIGEST=$(cat bazel-bin/setup-robot.digest) | |||
There was a problem hiding this comment.
Also need to change line 86 and replace --dst with --repository and --tag. Same for .github/ci/common.sh:99
|
I've got this error: https://gist.github.com/ensonic/9560e2a058ff30fa0cdfed36304938e3 |
|
If it is hard to fix we can use |
|
This is work now for me. I also did a 2nd run after bazel clean --expunge. |
ensonic
approved these changes
Jul 13, 2023
This makes it possible to debug tests that only occur on CI.
it looks like the 'broken' behavior does not exist in container_oci and the workaround now causes a breakage.
therjak
force-pushed
the
cschiemann/oci-image
branch
from
d407c09
to
9082ecd
Compare
faximan
added a commit
that referenced
this pull request
Jul 24, 2023
After #163 this file was no longer present, which manifests as a broken postsubmit: https://console.cloud.google.com/cloud-build/builds;region=europe-west1/a9a2ed28-0966-49ae-acb4-5e6b11187010;step=1?project=robco-integration-test Also fixing a missing rename in #159 Postsubmit passes with this PR: https://pantheon.corp.google.com/cloud-build/builds;region=europe-west1/6e67162e-b19d-435a-8726-15c3bf202255?project=robco-integration-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.