Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore comments which have been lost in the Bzlmod migration #443

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mering
Copy link
Contributor

@mering mering commented Sep 20, 2024

We can now specify platform directly, so we use the manifest and platform now directly and the outdated comment for debian-iptables has been removed.

The iptables_base image doesn't have a latest tag: https://pantheon.corp.google.com/gcr/images/google-containers/GLOBAL/debian-iptables

Copy link
Contributor

@ensonic ensonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We can now specify platform directly, so we use the manifest and platform now directly and the outdated comment for debian-iptables has been removed.
@mering mering merged commit 04ae82b into main Sep 20, 2024
5 checks passed
@mering mering deleted the fixup-rules-oci branch September 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants