Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Geocode by place id #427

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

andyklimczak
Copy link
Contributor

Geocode endpoint accepts a place_id param as an alternative to geocode
Google docs: https://developers.google.com/maps/documentation/geocoding/requests-places-geocoding

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jpoehnelt
Copy link
Contributor

mind rebasing? i just fixed the tests in #428

Geocode endpoint accepts a `place_id` param as an alternative to geocode
Google docs: https://developers.google.com/maps/documentation/geocoding/requests-places-geocoding
@andyklimczak
Copy link
Contributor Author

Rebased and CLA signed

@andyklimczak
Copy link
Contributor Author

True closes #207

@jpoehnelt jpoehnelt merged commit 1364711 into googlemaps:master Feb 2, 2022
@jpoehnelt
Copy link
Contributor

Thanks!!!

googlemaps-bot pushed a commit that referenced this pull request Feb 2, 2022
# [4.6.0](v4.5.3...v4.6.0) (2022-02-02)

### Features

* Geocode by place id ([#427](#427)) ([1364711](1364711))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andyklimczak
Copy link
Contributor Author

Thank you! Appreciate the quick response 🍕

@andyklimczak andyklimczak deleted the geocode-place-id branch February 2, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants