Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new BiDi ControlPosition constants #548

Closed
usefulthink opened this issue Nov 3, 2023 · 0 comments · Fixed by #571 or #569
Closed

Add new BiDi ControlPosition constants #548

usefulthink opened this issue Nov 3, 2023 · 0 comments · Fixed by #571 or #569
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@usefulthink
Copy link
Contributor

usefulthink commented Nov 3, 2023 •
edited
Loading

The latest version of the maps API added a couple of constants to the google.maps.ControlPosition enum. Those should be in the mocks as well. The Map.controls array has to be extended with those new arrays as well
@usefulthink usefulthink added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 3, 2023
usefulthink added a commit to usefulthink/js-jest-mocks that referenced this issue Nov 30, 2023
@usefulthink
fix: add new ControlPosition constants
cfd2182 
fixes googlemaps#548
@usefulthink usefulthink mentioned this issue Nov 30, 2023
Merged
usefulthink added a commit that referenced this issue Nov 30, 2023
@usefulthink
fix: add new ControlPosition constants (#571)
a33a39d 
fixes #548
github-actions bot pushed a commit that referenced this issue Nov 30, 2023
@googlemaps-bot
fix: add new ControlPosition constants (#571)
9654195 
fixes #548 a33a39d
@googlemaps-bot googlemaps-bot mentioned this issue Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@usefulthink