Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subkeys #1843

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Allow subkeys #1843

merged 1 commit into from
Mar 21, 2021

Conversation

dominikschulz
Copy link
Member

Fixes #1841
Fixes #1842

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz dominikschulz added the bug Defects label Mar 16, 2021
@dominikschulz dominikschulz added this to the 1.12.3 milestone Mar 16, 2021
AnomalRoil
AnomalRoil previously approved these changes Mar 17, 2021
This commit removes some erroneus extra logic that did prevent
us from passing through subkeys.

Fixes gopasspw#1841
Fixes gopasspw#1842

RELEASE_NOTES=[BUGFIX] Allow subkeys

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz marked this pull request as ready for review March 21, 2021 17:25
@dominikschulz dominikschulz merged commit 51595ce into gopasspw:master Mar 21, 2021
@dominikschulz dominikschulz deleted the fix/issue-1842 branch March 21, 2021 17:33
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
This commit removes some erroneus extra logic that did prevent
us from passing through subkeys.

Fixes gopasspw#1841
Fixes gopasspw#1842

RELEASE_NOTES=[BUGFIX] Allow subkeys

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gopass does not honor .gpg-id correctly Gopass is unable to add subkeys of a key individually
2 participants