Using sane default for partial config #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TM2500
pushed a commit
to TM2500/gopass
that referenced
this pull request
Nov 25, 2021
RELEASE_NOTES=[BUGFIX] Use same default for partial config files This is also upgrading the documentation regarding setup as we didn't reflect the move to the .local dir in there yet. Fixes gopasspw#1654 Fixes gopasspw#1967 Signed-off-by: Yolan Romailler <yolan@romailler.ch> Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
RELEASE_NOTES=[BUGFIX] Use same default for partial config files This is also upgrading the documentation regarding setup as we didn't reflect the move to the .local dir in there yet. Fixes gopasspw#1654 Fixes gopasspw#1967 Signed-off-by: Yolan Romailler <yolan@romailler.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_NOTES=[BUGFIX] Use same default for partial config files
This is also upgrading the documentation regarding setup as we didn't reflect the move to the .local dir in there yet.
I've also removed most special cases for config in the tests, since now our defaults are as they should be.
I let the
exportkeyone set to false since I figured we didn't want to export keys during testing unless testing explicitly that.This fixes #1654 and fixes #1967
Notice this doesn't remove the need for #1819.