Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make msi #2241

Merged
merged 1 commit into from
May 30, 2022
Merged

Add make msi #2241

merged 1 commit into from
May 30, 2022

Conversation

dominikschulz
Copy link
Member

Fixes #2038

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz dominikschulz added this to the 1.14.3 milestone May 29, 2022
Fixes gopasspw#2038

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz
Copy link
Member Author

I gave it a quick try on Windows 10. It produces a valid MSI installer that (silently) installs gopass to the users AppDir.
Not sure if that's what Windows users expect, but it does work.

We can change it to a system install, but that will then require elevated privileges.

Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

helpers/msipkg/main.go Show resolved Hide resolved
@dominikschulz dominikschulz merged commit 88fbd57 into gopasspw:master May 30, 2022
@dominikschulz dominikschulz deleted the rel/msi branch May 30, 2022 17:38
@AnomalRoil AnomalRoil mentioned this pull request May 31, 2022
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Fixes gopasspw#2038

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release fails with make msi missing
2 participants