Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Windows releaser #2251

Merged
merged 1 commit into from
May 31, 2022
Merged

Fixing Windows releaser #2251

merged 1 commit into from
May 31, 2022

Conversation

AnomalRoil
Copy link
Member

This should correct our issue:

✅ Current version is: 1.14.3
✅ Wrote Wix XML config to: /tmp/gopass-880485264/wix.xml
✅ Created MSI package at: dist/gopass-x64-windows-1.14.3.msi

stat dist/gopass-1.14.3-windows-x64.msi: no such file or directory

So we need to change the path to the correct gopass-x64-windows-1.14.3.msi instead.

@AnomalRoil
Fixing Windows releaser
2469429 
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
dominikschulz
dominikschulz approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit 0df4bc0 into master May 31, 2022
@dominikschulz dominikschulz deleted the win/release branch May 31, 2022 11:19
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
@AnomalRoil
Fixing Windows releaser (gopasspw#2251)
fb926df 
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnomalRoil @dominikschulz