-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding screen parsing for OTP QR code #2597
Conversation
59a2477
to
4a7234b
Compare
[CLEANUP] Fixing issues from linter Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
What should we do about the license @dominikschulz ? To me it seems okay since we already have deps using the BSD license, but not sure. The generator part with the WTFPL license is fine too. |
BSD is definitely fine with me. WTFPL should be ok as well. |
The problem is it's slightly different, it has an extra clause:
|
This is fine. We won't do that 🙂 |
Should I add WTFPL to the Edit: I went ahead and I've done it now it passes on CI. PS: note the big point here is that it requires CGO to work on Darwin (which our Goreleaser based process and cross-compilation pipeline doesn't support. A way to solve it might be to run Goreleaser from a darwin runner, or just to leave that feature to people willing to compile it themselves, which is the case for now.) It works fine without CGO on other Unix systems and on Windows. |
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Thank you. I will review the rest of the PR later (soon). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nit: Usually I prefer to split updating dependencies and code changes, but this time we can leave it as is.
This adds the capability to parse the content of the (multiple) display of the user to detect and add an OTP QR code to a given entry.
Usage:
I also updated our dependencies, while I was at it, by running
go get -u -t ./...
andgo mod tidy
.