[BUGFIX] Disabling the OTP snip screenshot feature on OpenBSD #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… problems Also do not rely on our dependency returning an error on Darwin and disable that too if it's not compiled with CGO Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
jrick
reviewed
Nov 4, 2023
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
dominikschulz
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the OTP snip screenshot feature on OpenBSD as discussed in #2683.
Also do not rely on our dependency returning an error on Darwin and disable that too if it's not compiled with CGO.
@dominikschulz If you have a Darwin device handy, it'd be cool if you could test the
gopass otp -snip testentryfeature with this branch both with and without CGO enabled to confirm whether it works fine or not.should do it.