Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jasoet] Enable Support for Yaml Config #5

Merged
merged 6 commits into from
Sep 25, 2019
Merged

[Jasoet] Enable Support for Yaml Config #5

merged 6 commits into from
Sep 25, 2019

Conversation

jasoet
Copy link
Collaborator

@jasoet jasoet commented Sep 25, 2019

No description provided.

@jasoet jasoet self-assigned this Sep 25, 2019
walbertus
walbertus approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@walbertus walbertus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantoel

BimoZX
BimoZX reviewed Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@BimoZX BimoZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use _ instead of . as a separator.

config.yaml Show resolved Hide resolved
@jasoet jasoet merged commit e51cc1b into master Sep 25, 2019
@jasoet jasoet deleted the yaml branch September 25, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BimoZX BimoZX BimoZX approved these changes

@mazbergaz mazbergaz mazbergaz approved these changes

@walbertus walbertus walbertus approved these changes

Assignees

@jasoet jasoet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasoet @BimoZX @mazbergaz @walbertus