Fix wifi connection for Windows #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Yeah, that file could certainly use some love on the Windows side. I just merged a commit to fix one of the github-actions workflows. Can you rebase your branch off of main to re-run the pre-merge checks? |
tcamise-gpsw
requested changes
Jun 25, 2021
tcamise-gpsw
previously approved these changes
Jun 25, 2021
|
K, it looks good to me. I'm going to do some additional manual testing with MacOS and Ubuntu before merging though. |
tcamise-gpsw
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native command to check for the existence of programs on Windows is
whereinstead ofwhich. Also, the correct way to escape ampersand (&) in xml would be&. After these changes, I am now able to connect on Windows.