forked from flupke/cython-setuptools
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General upgrades to Python3 with warning fix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreglia-gpsw
force-pushed
the
mtreglia/fix-warning
branch
from
February 28, 2024 10:27
3921161
to
a1f7572
Compare
mtreglia-gpsw
changed the title
vendor: remove cpp_str and tags after usage
vendor: remove cpp_str and tags after usage with minimal upgrade
Feb 28, 2024
mtreglia-gpsw
changed the title
vendor: remove cpp_str and tags after usage with minimal upgrade
General upgrades to Python3 with warning fix
Feb 28, 2024
mtreglia-gpsw
requested review from
mrobertseidowsky-gpsw,
lbertho-gpsw and
pierretran-gpsw
February 28, 2024 10:37
lbertho-gpsw
approved these changes
Feb 28, 2024
@@ -4,18 +4,18 @@ isolated_build = true | |||
|
|||
[gh-actions] | |||
python = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in commit message
This will prevent this type of warning: .sx/stupeflix/lib/python3.10/site-packages/setuptools/_distutils/extension.py:134: UserWarning: Unknown Extension options: 'cpp_std', 'tags' warnings.warn(msg) It's wrong to forward the keyword 'cpp_std' and 'tags' to cython.Extension and the latter is used to fill the extra_compile_args in: https://github.com/gopro/cython-setuptools/blob/main/cython_setuptools/vendor.py#L295-L296
mtreglia-gpsw
force-pushed
the
mtreglia/fix-warning
branch
from
February 28, 2024 15:18
6a12c93
to
ea69e47
Compare
mrobertseidowsky-gpsw
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me after adding tag 0.3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
* Bump integration test to Python3
* Bump base tox python to 3.10
* Bump gitactions checkout and setup-python versions
* Fix Warning
This will prevent this type of warning:
.sx/stupeflix/lib/python3.10/site-packages/setuptools/_distutils/extension.py:134:
UserWarning: Unknown Extension options: 'cpp_std', 'tags' warnings.warn(msg)
It's wrong to forward the keyword 'cpp_std' and 'tags' to cython.Extension and the latter is used to fill the extra_compile_args in:
https://github.com/gopro/cython-setuptools/blob/main/cython_setuptools/vendor.py#L295-L296