allow the image_size option to be set as a symbol

gouravmodi · Feb 17, 2015 · d541116 · d541116
1 parent 9c93c08
commit d541116
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/omniauth/strategies/facebook.rb b/lib/omniauth/strategies/facebook.rb
@@ -190,7 +190,7 @@ def image_url(uid, options)
         site_uri = URI.parse(client.site)
         url = uri_class.build({:host => site_uri.host, :path => "#{site_uri.path}/#{uid}/picture"})
 
-        query = if options[:image_size].is_a?(String)
+        query = if options[:image_size].is_a?(String) || options[:image_size].is_a?(Symbol)
           { :type => options[:image_size] }
         elsif options[:image_size].is_a?(Hash)
           options[:image_size]

diff --git a/test/test.rb b/test/test.rb
@@ -120,6 +120,13 @@ class InfoTest < StrategyTestCase
     assert_equal 'http://graph.facebook.com/321/picture?type=normal', strategy.info['image']
   end
 
+  test 'returns the image with size specified as a symbol in the `image_size` option' do
+    @options = { :image_size => :normal }
+    raw_info = { 'name' => 'Fred Smith', 'id' => '321' }
+    strategy.stubs(:raw_info).returns(raw_info)
+    assert_equal 'http://graph.facebook.com/321/picture?type=normal', strategy.info['image']
+  end
+
   test 'returns the image with width and height specified in the `image_size` option' do
     @options = { :image_size => { :width => 123, :height => 987 } }
     raw_info = { 'name' => 'Fred Smith', 'id' => '321' }