forked from AIDASoft/podio
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request AIDASoft#72 from vvolkl/upstream-changes
Upstream changes from AIDASoft
- Loading branch information
Showing
73 changed files
with
1,332 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Contribution Guidelines for PODIO | ||
|
||
|
||
## Pull Requests | ||
|
||
When making a `Pull Request` please explain what and why things were | ||
changed. Please include a short description in the | ||
BEGINRELEASENOTES/ENDRELEASENOTES block, which will appear in the | ||
doc/ReleaseNotes.md, once a new tag is made. | ||
|
||
We are happy if you create pull-requests also if you feature is not ready, yet. | ||
Please mark them as such by adding `[WIP]` to the start of the title. The purpose | ||
of this is, for example, that you want to let other people know you are working | ||
on a given issue. For these work-in-progress pull-request, we propose to have a | ||
check list of things that still need to be done. | ||
|
||
## Issue tracking | ||
|
||
Use the GitHub issue tracker. Reference the issues that you are working on. | ||
If you notice an issue, consider first creating an issue and then refering to it | ||
in your pull-request and commit messages with `#[issue-id]`. | ||
|
||
## Coding Conventions | ||
|
||
* Your code should not introduce any new warnings, and fix as many existing warnings as possible | ||
|
||
## Git workflow | ||
|
||
For an explanation of the git(hub) workflow please see | ||
[here](https://github.com/andresailer/tutorial#working-updating-pushing). We | ||
basically follow the ["No Switch | ||
Yard"](https://root.cern.ch/suggested-work-flow-distributed-projects-nosy) | ||
workflow | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
!!!IMPORTANT!!!: To facilitate faster and easier response to your issue please provide in addition to the description of the issue also the following information | ||
|
||
- OS version: e.g. SLC6 | ||
- Compiler version: e.g GCC 6.2 | ||
- PODIO version: tag or commit ID, or GitHub branch | ||
- Reproduced by: exact steps to reproduce the problem: checkout, setup environment (Geant, ROOT versions, iLCSoft release), cmake, build, run... | ||
- Input: link to input files if applicable | ||
- Output: full build and run log output | ||
- Goal: A short description of what you are trying to achieve |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
|
||
|
||
BEGINRELEASENOTES | ||
- Thank you for writing the text to appear in the release notes. It will show up | ||
exactly as it appears between the two bold lines | ||
- ... | ||
|
||
ENDRELEASENOTES |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
build | ||
install | ||
*pyc | ||
*pyc | ||
*~ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.