-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate K8s quickstart manifests to tanka v2 #1437
Conversation
I've integrated all the review comments. Note that we should hold off on merging this until the onboarding plugin instructions and docs changes are ready to go (although this is a bit of a chicken-egg situation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge block to prevent accidental merges; feel free to dismiss once it's ready to go
@hjet following up on this, do you know if this is safe to merge now? |
(Mostly) safe to merge per https://github.com/grafana/cloud-docs/pull/142 however it would be prudent to also restart all hosted Grafana instances to pick up the latest version of the plugin to eliminate all possible stale references to |
Going to work through the merge conflict in a bit |
@rfratto just rebased, should be good to go. i decided to use defaults for the HTTP port/server everywhere, will create issues in the cloud-docs repo to track the required config/configmap changes. those docs are versioned now (to |
See https://github.com/grafana/cloud-docs/issues/143 for Cloud docs issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % one small nit
PR Description
This PR migrates the generation of K8s manifests in
production/kubernetes
tov2
of the Tanka jsonnet library.Summary of changes to manifests:
80
from misc other ports (8080
,12345
, etc)agent-bare.yaml
StatefulSet
(prevDeployment
)StatefulSet
agent-loki.yaml
machine-id
(journal) vol disabled by defaultagent-traces.yaml
TODO
in a future PR: add this to tanka/v2 jsonnet library)Which issue(s) this PR fixes
Fixes #451
Notes to the Reviewer
Still need to test these on clusters and update docs but submitting for preliminary reviewTested manifests on a DOKS cluster
PR Checklist