Add base agent-operator tanka config #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captncraig
reviewed
Jul 13, 2022
| local this = self, | ||
|
|
||
| _images:: { | ||
| agent_operator: 'grafana/agent-operator:v0.26.0-rc.0', |
There was a problem hiding this comment.
I'm a little worried this image is in a bad place, and will not be updated very easily. The agent libs import lib/version.libsonnet. Maybe make another operator version file, or I think preferably change version.libsonnet into a file like images.libsonnet and have both images in one place.
There was a problem hiding this comment.
ah i thought lib/version.libsonnet was deprecated since those manifests aren't generated anymore - was just matching the approach used in the agent tanka lib - happy to create a new version file though and use that in the agent, operator, etc. base libs
|
LGTM, besides Craig's feedback. |
captncraig
approved these changes
Jul 14, 2022
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a library to generate the base agent-operator manifest found here. Subsequent PRs will cover the CRs (metrics, logs, etc.) in the custom resource quickstart.
Will investigate using the k8s library, which seems to generate the jsonnet libraries from the CRDs directly...
This work is to support the addition of generated agent-operator configs in Grafana Cloud K8s monitoring.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist