Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet/river: add jsonnet library to build River configs #1974

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jul 29, 2022

Add a jsonnet/river library which can be used to construct River configs.

I decided to put this at the top-level rather than in production/tanka. Let me know if you think it should be moved.

@rfratto rfratto changed the title jsonnet/river: add jsonnet library to build River configs. jsonnet/river: add jsonnet library to build River configs Jul 29, 2022
@rfratto
Copy link
Member Author

rfratto commented Aug 3, 2022

We should probably move this to an operations/river-jsonnet folder instead to align with Mimir's operations folder.

I'm not a fan of production since it implies production readiness, while operations wouldn't.

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto enabled auto-merge (squash) August 4, 2022 12:52
@rfratto rfratto merged commit 8d61a7d into grafana:main Aug 4, 2022
@rfratto rfratto deleted the river-jsonnet branch August 4, 2022 13:58
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants