Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow: evaluate everything in queue when queue changes #1996

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Aug 8, 2022

This fixes a bug where only a single changed component was reevaluated, even if other components were in the queue. This potentially caused some components to never get evaluated, depending on the luck of the draw from what gets dequeued.

This fixes a bug where only a single changed component was reevaluated,
even if other components were in the queue. This potentially caused some
components to never get evaluated, depending on the luck of the draw
from what gets dequeued.
@rfratto rfratto requested a review from gouthamve August 8, 2022 09:41
@rfratto rfratto enabled auto-merge (squash) August 8, 2022 09:45
@rfratto rfratto requested a review from a team August 8, 2022 09:47
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most familiar with this codebase, but I've gone through the controller.Queue implementation and this makes sense.

@rfratto rfratto merged commit e922fc8 into grafana:main Aug 8, 2022
@rfratto rfratto deleted the flow-dequeue-everything branch August 8, 2022 10:14
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants