Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow reuse updates #2368

Merged

Conversation

karengermond
Copy link
Contributor

@karengermond karengermond commented Oct 14, 2022

PR Description

Create and add snippets where possible using the docs/shared shortcode as in #2341.

Which issue(s) this PR fixes

#2364

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@karengermond karengermond linked an issue Oct 14, 2022 that may be closed by this pull request
@karengermond
Copy link
Contributor Author

@rfratto @mattdurham There are a lot of files in the PR because I ran the alias checker:

docker run -i -v "$(pwd)/sources:/sources" grafana/automatic-aliases:latest /sources /docs/agent ''

Hope that was OK.

@rfratto
Copy link
Member

rfratto commented Oct 14, 2022

Hmm, some of the aliases seem wrong (like the cookbook ones have weird links, and some of the Flow ones are losing the Flow prefix), I'll need to go through them carefully on Monday to check

@karengermond
Copy link
Contributor Author

karengermond commented Oct 14, 2022

Sorry, I could create a new branch with the files I actually updated if that's easier. Let me know. Eve showed me the script but I wonder if it was only meant for the cloud-docs repo.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +22 to +29
The following sub-blocks are supported for `http_client_config`:

Name | Description | Required
---- | ----------- | --------
[`basic_auth`](#basic_auth-block) | Configure basic_auth for authenticating against Kubernetes. | no
[`authorization`](#authorization-block) | Configure generic authorization against Kubernetes. | no
[`oauth2`](#oauth2-block) | Configure OAuth2 for authenticating against Kubernetes. | no
[`tls_config`](#tls_config-block) | Configure TLS settings for connecting to Kubernetes. | no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we stopped documenting subblocks in the content of a block now and we use the blocks header instead to describe the hierarchy. Should we remove this section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update that in a following PR.

@karengermond karengermond merged commit db43e16 into main Oct 17, 2022
@karengermond karengermond deleted the 2364-implement-reuse-for-existing-flow-reference-topics branch October 17, 2022 17:40
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Implement reuse for existing Flow reference topics
2 participants