-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow reuse updates #2368
Flow reuse updates #2368
Conversation
@rfratto @mattdurham There are a lot of files in the PR because I ran the alias checker:
Hope that was OK. |
Hmm, some of the aliases seem wrong (like the cookbook ones have weird links, and some of the Flow ones are losing the Flow prefix), I'll need to go through them carefully on Monday to check |
Sorry, I could create a new branch with the files I actually updated if that's easier. Let me know. Eve showed me the script but I wonder if it was only meant for the cloud-docs repo. |
This reverts commit 19971ce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The following sub-blocks are supported for `http_client_config`: | ||
|
||
Name | Description | Required | ||
---- | ----------- | -------- | ||
[`basic_auth`](#basic_auth-block) | Configure basic_auth for authenticating against Kubernetes. | no | ||
[`authorization`](#authorization-block) | Configure generic authorization against Kubernetes. | no | ||
[`oauth2`](#oauth2-block) | Configure OAuth2 for authenticating against Kubernetes. | no | ||
[`tls_config`](#tls_config-block) | Configure TLS settings for connecting to Kubernetes. | no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think we stopped documenting subblocks in the content of a block now and we use the blocks header instead to describe the hierarchy. Should we remove this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update that in a following PR.
PR Description
Create and add snippets where possible using the docs/shared shortcode as in #2341.
Which issue(s) this PR fixes
#2364
Notes to the Reviewer
PR Checklist