integrations: add missing setting to override eventhandler instance #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctc
requested review from
karengermond,
rgeyer,
gaantunes and
captncraig
as code owners
rfratto
reviewed
Oct 26, 2022
| @@ -38,7 +39,8 @@ type Config struct { | |||
| // If you would like to limit events to a given namespace, use this parameter. | |||
| Namespace string `yaml:"namespace,omitempty"` | |||
| // Extra labels to append to log lines | |||
| ExtraLabels labels.Labels `yaml:"extra_labels,omitempty"` | |||
| ExtraLabels labels.Labels `yaml:"extra_labels,omitempty"` | |||
| Common common.MetricsConfig `yaml:",inline"` | |||
There was a problem hiding this comment.
I don't think embedding all of MetricsConfig is appropriate here because eventhandler is a logging integration. Can we manually copy the instance key field instead of bringing in everything else?
tpaschalis
approved these changes
Oct 27, 2022
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As part of the effort of completing #2017 we realized that eventhandler integration
didn't include
instanceinto the config which allows also to override the instancekey for that integration.
Which issue(s) this PR fixes
#2366
PR Checklist