Add Cloudwatch metrics integration #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kgeckhart
reviewed
Jan 17, 2023
kgeckhart
reviewed
Jan 23, 2023
kgeckhart
reviewed
Jan 23, 2023
thepalbi
force-pushed
the
pablo/add-yace-integration
branch
from
14ac66f
to
f5acc7d
Compare
kgeckhart
reviewed
Jan 23, 2023
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
thepalbi
requested review from
karengermond,
rgeyer,
gaantunes and
captncraig
as code owners
Co-authored-by: MattNolf <86960799+matthewnolf@users.noreply.github.com>
marctc
reviewed
Jan 30, 2023
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
|
@marctc all comments have been resolved. Can you take another look? |
marctc
approved these changes
Jan 31, 2023
karengermond
approved these changes
Jan 31, 2023
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
docs/sources/configuration/integrations/cloudwatch-exporter-config.md
Outdated
Show resolved
Hide resolved
…nfig.md Co-authored-by: Karen Germond <110922559+karengermond@users.noreply.github.com>
Co-authored-by: Karen Germond <110922559+karengermond@users.noreply.github.com>
|
@marctc @karengermond all docs comments fixed 😃 |
marctc
reviewed
Jan 31, 2023
marctc
reviewed
Jan 31, 2023
thepalbi
commented
Jan 31, 2023
| @@ -25,6 +25,8 @@ Main (unreleased) | |||
|
|
|||
| - Integrations: Introduce the `mssql` integration. (@binaryfissiongames) | |||
|
|
|||
| - Integrations: Introduce `cloudwatch metrics` integration. (@thepalbi) | |||
There was a problem hiding this comment.
@marctc just fixed it. Terrible mistake trying to merge conflicts with the gh ui 🤦
3 tasks
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add support for scraping AWS CloudWatch metrics, by embedding YACE as an integration.
Which issue(s) this PR fixes
Resolves https://github.com/grafana/cloud-onboarding/issues/2976
Notes to the Reviewer
PR Checklist