Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace go4.org/unsafe/assume-no-moving-gc until it's updated for Go 1.20 #2915

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Feb 2, 2023

No description provided.

k8s.io/klog/v2 v2.80.1
k8s.io/utils v0.0.0-20221128185143-99ec85e7a448
sigs.k8s.io/controller-runtime v0.13.1
sigs.k8s.io/yaml v1.3.0
)

require (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I combined the requires and re-ran go mod tidy, I'm not sure why we ended up with two of these at some point.

Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto enabled auto-merge (squash) February 2, 2023 20:59
@rfratto rfratto merged commit b6674a8 into grafana:main Feb 2, 2023
@rfratto rfratto deleted the replace-unsafe-assume-no-moving-gc branch February 2, 2023 22:27
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants