Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki.process: fix deadlock on components with no stages #3299

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Mar 16, 2023

This fixes a deadlock when loki.process has no stages defined, since previously it needed at least one stage to create the input pipelines.

This fixes a deadlock when loki.process has no stages defined, since
previously it needed at least one stage to create the input pipelines.
Copy link
Contributor

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smooth

@rfratto rfratto enabled auto-merge (squash) March 16, 2023 21:12
@rfratto rfratto merged commit 43f05e3 into grafana:main Mar 16, 2023
@rfratto rfratto deleted the loki.process-fix-deadlock-no-stages branch March 16, 2023 21:22
@tpaschalis
Copy link
Member

Whoops, thanks for the catch!

clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
This fixes a deadlock when loki.process has no stages defined, since
previously it needed at least one stage to create the input pipelines.
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
This fixes a deadlock when loki.process has no stages defined, since
previously it needed at least one stage to create the input pipelines.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants