Contributing guide (and related) clean up #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thampiotr
commented
Apr 13, 2023
| @@ -1,7 +1 @@ | |||
| pkg/operator/crds/*.yaml linguist-generated=true | |||
|
|
|||
| # Git on Windows may automatically check out files with crlf line endings, | |||
| # which breaks the Fuzz parser in 1.18 (golang/go#52268). A fix is scheduled | |||
There was a problem hiding this comment.
This issue is solved in 1.19 and we use Go 1.19 as per go.mod.
thampiotr
commented
Apr 13, 2023
Comment on lines
-1858
to
-1859
| github.com/grafana/process-exporter v0.7.3-0.20210106202358-831154072e2a h1:JUnP/laSl2GylHT0+fqAqOZY+7XkLh1mLefLN0n8Mmk= | ||
| github.com/grafana/process-exporter v0.7.3-0.20210106202358-831154072e2a/go.mod h1:RMjrx3Qn8l2pgCD27g45xbko4UDpVVuHC8Cd2YXPtWA= |
There was a problem hiding this comment.
go mod tidy removed this and I didn't find any imports in the source. I hope it's not here for some magic purpose?
There was a problem hiding this comment.
No, we just don't have a CI step (yet) trying to make sure the go.sum is always tidied, so sometimes this happens.
thampiotr
force-pushed
the
thampiotr/contributing-guide-cleanup
branch
from
e9558b1
to
5a6eb34
Compare
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Minor clean up performed while following the contributing guide.
Mostly related to the fact that we now use Go 1.19.
Which issue(s) this PR fixes
N/A - trivial fixes and improvements such as this one do not require an issue.