Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

river/stdlib: add nonsensitive function #3817

Merged
merged 6 commits into from
May 9, 2023
Merged

river/stdlib: add nonsensitive function #3817

merged 6 commits into from
May 9, 2023

Commits on May 9, 2023

  1. move flow/rivertypes package to river/rivertypes 

    With the intent to add a `nonsensitive` function into the standard
library, rivertypes needs to be moved under river/ to allow it to
eventually remove import cycles.

Plus, given a `nonsensitive` function, the river/ package would be a
better home for the rivertypes package, since the River stdlib should
not import anything outside of River.
    @rfratto
    rfratto committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8ad5414 View commit details
    Browse the repository at this point in the history

  2. rivertypes: remove import on river 

    This commit modifies rivertypes to import types through the internal
value package instead of the top-level river package. This removes a
potential import cycle allows the stdlib to import rivertypes.
    @rfratto
    rfratto committed May 9, 2023
    Configuration menu
    Copy the full SHA
    93e5e41 View commit details
    Browse the repository at this point in the history

  3. river/stdlib: add nonsensitive function 

    The `nonsensitive` function allows users to explicitly convert a secret
value back to a string.

`nonsensitive` is primarily useful when combined with the remote.vault
component, since remote.vault always returns secrets, even if some data
stored in Vault is non-sensitive (such as a TLS public key).
    @rfratto
    rfratto committed May 9, 2023
    Configuration menu
    Copy the full SHA
    145ffa0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into river-nonsensitive

    @rfratto
    rfratto committed May 9, 2023
    Configuration menu
    Copy the full SHA
    63e614e View commit details
    Browse the repository at this point in the history

  5. remote.vault: document usage of nonsensitive in exports

    @rfratto
    rfratto committed May 9, 2023
    Configuration menu
    Copy the full SHA
    153d281 View commit details
    Browse the repository at this point in the history

  6. address review feedback

    @rfratto
    rfratto committed May 9, 2023
    Configuration menu
    Copy the full SHA
    99588d5 View commit details
    Browse the repository at this point in the history