-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and correct Grafana Agent Static install on Linux #3931
Conversation
Changes to the topic:
|
@marctc @zeitlinger Can one of you take a look over the changes I'm suggesting here. The main updates are around the new openSUSE. The other changes are generally markdown cleanup. I've tested the openSUSE section and it all seems to work correctly. |
I'm not an expert on the agent - what should I look at in particular? |
In particular, I'd like some developer eyes on:
(everything else that was changed is cosmetic) |
I'm also not familiar with that - please reach out to the #agent team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Reviewed and ready to merge |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3931-to-release-v0.32 origin/release-v0.32
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 4b8807a517071556c7fd520d7ddd792fbcd311f7
# Push it to GitHub
git push --set-upstream origin backport-3931-to-release-v0.32
git switch main
# Remove the local backport branch
git branch -D backport-3931-to-release-v0.32 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3931-to-release-v0.33 origin/release-v0.33
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 4b8807a517071556c7fd520d7ddd792fbcd311f7
# Push it to GitHub
git push --set-upstream origin backport-3931-to-release-v0.33
git switch main
# Remove the local backport branch
git branch -D backport-3931-to-release-v0.33 Then, create a pull request where the |
* First pass correcting Static install Linux * Correct some details for openSUSE * Simplify openSUSE step * Update heading levels (cherry picked from commit 4b8807a)
Backported to v0.33. Removed backport to v0.32. |
* First pass correcting Static install Linux * Correct some details for openSUSE * Simplify openSUSE step * Update heading levels
* First pass correcting Static install Linux * Correct some details for openSUSE * Simplify openSUSE step * Update heading levels
PR Description
The existing Grafana Agent Static install docs for Linux are not formatted correctly (markdown errors) and are not correct for openSUSE.
Issue: #3903
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist