Support producing delta profiles in Pyroscope scrape component #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't made any documentation change because I don't think this is worth knowing from a user standpoint. |
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces the computation of delta profiles in
pyroscope.scrapecomponent before shipping them to the target. This is only done for some cumulative profile types. We're doing this to reduce the network bandwidth between the Agent and the server.Right now the pyroscope server does this but we think the agent is better place to reduce bandwidth and resource usage.
The first profile will return an error and be discarded.
Which issue(s) this PR fixes
Fixes grafana/phlare#694
Notes to the Reviewer
I had to copy datadog
fastdeltapackage as it is internal.PR Checklist
- [ ] Documentation added