Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promtail converters: encoding and decompression settings #4671

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Promtail converters: encoding and decompression settings #4671

merged 1 commit into from
Aug 2, 2023

Conversation

thampiotr
Copy link
Contributor

@thampiotr thampiotr commented Aug 1, 2023 •
edited
Loading

PR Description

Adds handling of encoding and decompression settings for promtail converters.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@thampiotr thampiotr marked this pull request as ready for review August 1, 2023 13:14
@thampiotr thampiotr requested a review from a team as a code owner August 1, 2023 13:14
@thampiotr thampiotr mentioned this pull request Aug 1, 2023
Merged
3 tasks
@thampiotr thampiotr force-pushed the thampiotr/promtail-converters-part-4 branch from 97ac724 to 04bcfed Compare August 1, 2023 14:44
erikbaranowski
erikbaranowski approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can merge tomorrow once you get a chance to see the small comment I had.

@thampiotr thampiotr force-pushed the thampiotr/promtail-converters-part-4 branch from d80c4d8 to 66ce073 Compare August 2, 2023 13:23
@erikbaranowski erikbaranowski merged commit 06d7df0 into main Aug 2, 2023
6 checks passed
@erikbaranowski erikbaranowski deleted the thampiotr/promtail-converters-part-4 branch August 2, 2023 13:40
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Aug 2, 2023
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
@thampiotr @clayton-cornell
Promtail converters: encoding and decompression settings (#4671)
88eb2a3
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
@thampiotr @clayton-cornell
Promtail converters: encoding and decompression settings (#4671)
08a11c0
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikbaranowski erikbaranowski erikbaranowski approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thampiotr @erikbaranowski @clayton-cornell