Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document positions file usage in loki.source.docker.md #4686

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

thampiotr
Copy link
Contributor

PR Description

I got a question regarding this and I'd prefer this was documented.

PR Checklist

  • Documentation added

@thampiotr thampiotr marked this pull request as ready for review August 2, 2023 11:42
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Aug 2, 2023
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase of one sentence... and LGTM.

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@tpaschalis tpaschalis merged commit 56d3113 into main Aug 3, 2023
6 checks passed
@tpaschalis tpaschalis deleted the thampiotr-patch-1 branch August 3, 2023 16:25
clayton-cornell added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants